Repository navigation
Parse table/mapcontinenttable.xml (2.4.38) - #97
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The emulator decides Shadow World behaviour by comparing a map's continent code to 202, a copy of a fact the client reads from
table/mapcontinenttable.xml. That table also says which continent's world map lists a map: Shadow World shows on Victoria Island's. Nothing parsed it, so the emulator had no way to read either fact. This adds the type andTableParser.ParseMapContinent().Xml/Table/MapContinent.cs, new: the four attributes eachcontinentrow carries,id,hideOtherWorldQuest,shadowContinentandrepresentWorldmapContinent.TableParser.cs:ParseMapContinent()yields each row by id. The file needs no sanitising.TableParserTest.TestMapContinent: continent 202 is a shadow continent listed under 102, and 102 is not a shadow continent, as the shipped XML states.The consumer is finding 23 of the emulator's untangle audit, MS2Community/PrivateMaple2#2266. Its commit is ready on a branch and moves to 2.4.38 once this is published.
Verification
dotnet build Maple2.File.Parsersucceeds with 0 warnings.TestMapContinentpasses against the GMS2 archives, alongsideTestPvpRankingDuelMode. I did not run the rest ofMaple2.File.Tests.2.4.38-debug.0pack of this branch was ingested by the emulator, and in game a Shadow World map applied its health buff on entry and removed it on leaving, and resolving the death penalty there cost 1.1 times the Victoria Island price. The world map listing rests on an emulator unit test, not a check in game.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit