Skip to content

Parse table/mapcontinenttable.xml (2.4.38) - #97

Merged
AngeloTadeucci merged 1 commit into
masterfrom
parse-map-continent
Nov 15, 2026
Merged

AngeloTadeucci merged 1 commit into
masterfrom
parse-map-continent

Conversation

@AngeloTadeucci

@AngeloTadeucci AngeloTadeucci commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

The emulator decides Shadow World behaviour by comparing a map's continent code to 202, a copy of a fact the client reads from table/mapcontinenttable.xml. That table also says which continent's world map lists a map: Shadow World shows on Victoria Island's. Nothing parsed it, so the emulator had no way to read either fact. This adds the type and TableParser.ParseMapContinent().

  • Xml/Table/MapContinent.cs, new: the four attributes each continent row carries, id, hideOtherWorldQuest, shadowContinent and representWorldmapContinent.
  • TableParser.cs: ParseMapContinent() yields each row by id. The file needs no sanitising.
  • TableParserTest.TestMapContinent: continent 202 is a shadow continent listed under 102, and 102 is not a shadow continent, as the shipped XML states.
  • Version: 2.4.38.

The consumer is finding 23 of the emulator's untangle audit, MS2Community/PrivateMaple2#2266. Its commit is ready on a branch and moves to 2.4.38 once this is published.

Verification

  • dotnet build Maple2.File.Parser succeeds with 0 warnings.
  • TestMapContinent passes against the GMS2 archives, alongside TestPvpRankingDuelMode. I did not run the rest of Maple2.File.Tests.
  • A local 2.4.38-debug.0 pack of this branch was ingested by the emulator, and in game a Shadow World map applied its health buff on entry and removed it on leaving, and resolving the death penalty there cost 1.1 times the Victoria Island price. The world map listing rests on an emulator unit test, not a check in game.

Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • New Features
    • Added support for reading continent data from the map tables, including continent IDs and properties describing shadow continents and represented world-map continents. Applications can now access these relationships alongside the other parsed table data.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The parser adds XML mappings for continent table data and a method that yields parsed continents with their IDs. A test checks selected continent values. The parser package version changes from 2.4.37 to 2.4.38.

Changes: Map continent parsing

Layer / File(s) Summary
Map continent XML mapping
Maple2.File.Parser/Xml/Table/MapContinent.cs
Adds XML-mapped root and continent types. The continent type maps four integer attributes.
Parser integration and validation
Maple2.File.Parser/TableParser.cs, Maple2.File.Tests/TableParserTest.cs, Maple2.File.Parser/Maple2.File.Parser.csproj
TableParser deserializes the map continent table and yields each continent with its ID. The test checks selected continent values. The parser package version changes to 2.4.38.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: zintixx, dreary

Merge Risk: Minimal · up to 93f66

This adds parsing for the map continent table without changing existing parser behavior. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Parse table/mapcontinenttable.xml (2.4.38)" matches the main change: a new ParseMapContinent() method in TableParser, new MapContinent XML types, and a test, all reading table/mapcontinentt…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Parse table/mapcontinenttable.xml (2.4.38)" matches the main change: a new ParseMapContinent() method in TableParser, new MapContinent XML types, and a test, all reading table/mapcontinenttable.xml. The version number in parentheses corresponds to the package version bump from 2.4.37 to 2.4.38 in the parser project. The title is specific and concise, and a teammate scanning history would understand the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a06f730-f259-4919-bb0c-7c543fe29996
Commits

Reviewing files that changed from the base of the PR and between 9fbddcc and 93f66c1.

Files selected for processing: 4

  • Maple2.File.Parser/Maple2.File.Parser.csproj
  • Maple2.File.Parser/TableParser.cs
  • Maple2.File.Parser/Xml/Table/MapContinent.cs
  • Maple2.File.Tests/TableParserTest.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@AngeloTadeucci
AngeloTadeucci merged commit 7cbe52b into master Nov 15, 2026
3 checks passed
@AngeloTadeucci
AngeloTadeucci deleted the parse-map-continent branch November 15, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant